Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: improve error message of runtime helper __require #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 25, 2024

Description

Dynamic require of "' + x + '" is not supported.

is really a confusing message.

Copy link
Member Author

hyf0 commented Nov 25, 2024

@hyf0 hyf0 force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from da49712 to ae91ea7 Compare November 25, 2024 17:55
@hyf0 hyf0 marked this pull request as ready for review November 25, 2024 17:55
@hyf0 hyf0 force-pushed the 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ branch 2 times, most recently from 4cf86da to 94a1a55 Compare November 25, 2024 17:57
@hyf0 hyf0 force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from ae91ea7 to 6ab7228 Compare November 25, 2024 17:57
Base automatically changed from 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ to main November 25, 2024 18:34
@hyf0 hyf0 force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from 6ab7228 to dbd7024 Compare November 25, 2024 18:35
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8a7ba82
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67454746a39e8c000839b554

Copy link
Member Author

hyf0 commented Nov 25, 2024

Merge activity

  • Nov 25, 1:36 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from dbd7024 to 8a7ba82 Compare November 26, 2024 03:57
@hyf0 hyf0 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 2140c92 Nov 26, 2024
19 checks passed
@hyf0 hyf0 deleted the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch November 26, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.