Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 087b8cb

Browse filesBrowse files
authored
Add logs in GitHubClient response. fix hub4j#1594
1 parent 472adbb commit 087b8cb
Copy full SHA for 087b8cb

File tree

Expand file treeCollapse file tree

1 file changed

+18
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+18
-2
lines changed

‎src/main/java/org/kohsuke/github/GitHubClient.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/GitHubClient.java
+18-2Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ public <T> GitHubResponse<T> sendRequest(GitHubRequest request, @CheckForNull Bo
430430
logRequest(connectorRequest);
431431
rateLimitChecker.checkRateLimit(this, request.rateLimitTarget());
432432
connectorResponse = connector.send(connectorRequest);
433+
logResponse(connectorResponse);
433434
noteRateLimit(request.rateLimitTarget(), connectorResponse);
434435
detectKnownErrors(connectorResponse, request, handler != null);
435436
return createResponse(connectorResponse, handler);
@@ -520,8 +521,23 @@ private GitHubConnectorRequest prepareConnectorRequest(GitHubRequest request) th
520521

521522
private void logRequest(@Nonnull final GitHubConnectorRequest request) {
522523
LOGGER.log(FINE,
523-
() -> "GitHub API request [" + (getLogin() == null ? "anonymous" : getLogin()) + "]: "
524-
+ request.method() + " " + request.url().toString());
524+
() -> String.format("(%s) GitHub API request [%s]: %s",
525+
Integer.toHexString(request.hashCode()),
526+
(getLogin() == null ? "anonymous" : getLogin()),
527+
(request.method() + " " + request.url().toString())));
528+
}
529+
530+
private void logResponse(@Nonnull final GitHubConnectorResponse response) {
531+
LOGGER.log(FINE, () -> {
532+
try {
533+
return String.format("(%s) GitHub API response [%s]: %s",
534+
Integer.toHexString(response.request().hashCode()),
535+
(getLogin() == null ? "anonymous" : getLogin()),
536+
(response.statusCode() + " " + GitHubResponse.getBodyAsString(response)));
537+
} catch (IOException e) {
538+
throw new RuntimeException(e);
539+
}
540+
});
525541
}
526542

527543
@Nonnull

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.