Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: refactor service_openraft.rs in PC #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

refactor: refactor service_openraft.rs in PC #1100

merged 6 commits into from
May 12, 2025

Conversation

PorterZhang2021
Copy link
Collaborator

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link

close #1099

socutes
socutes approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@socutes socutes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socutes socutes merged commit ddb4db8 into robustmq:main May 12, 2025
12 of 13 checks passed
@PorterZhang2021 PorterZhang2021 deleted the refactor-pc-openraft branch May 13, 2025 13:48
This was referenced May 15, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@socutes socutes socutes approved these changes

@LYZJU2019 LYZJU2019 Awaiting requested review from LYZJU2019

Assignees
No one assigned
Labels
kind:refactor Size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] refactor service_openraft in PC
2 participants
@PorterZhang2021 @socutes
Morty Proxy This is a proxified and sanitized view of the page, visit original site.