Shutdown callback#50
Open
es-m-se wants to merge 2 commits intorobotframework:masterrobotframework/PythonRemoteServer:masterfrom
es-m-se:shutdown_callbackes-m-se/PythonRemoteServer:shutdown_callbackCopy head branch name to clipboard
Open
Shutdown callback#50es-m-se wants to merge 2 commits intorobotframework:masterrobotframework/PythonRemoteServer:masterfrom es-m-se:shutdown_callbackes-m-se/PythonRemoteServer:shutdown_callbackCopy head branch name to clipboard
es-m-se wants to merge 2 commits intorobotframework:masterrobotframework/PythonRemoteServer:masterfrom
es-m-se:shutdown_callbackes-m-se/PythonRemoteServer:shutdown_callbackCopy head branch name to clipboard
Conversation
sync with base master
…led when stopping the remote server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Guys,
After the recent upgrades to the python remote server many of my scripts stopped working. I had been overloading signal catching function to implement my own shutdown sequence. Many of my remote scripts were running multiple threads. In the new version that function disappeared.
I'd like to suggested this minor feature adding a shuddown_callback to the remote server. With this it is possible to run complex remotes and ensure they will stop properly.
Thanks for your consideration
Shannon