Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add SSD1315 OLED driver support#410

Merged
rm-hull merged 2 commits intorm-hull:mainrm-hull/luma.oled:mainfrom
Kihltech:feature/ssd1315Kihltech/luma.oled:feature/ssd1315Copy head branch name to clipboard
Feb 26, 2026
Merged

Add SSD1315 OLED driver support#410
rm-hull merged 2 commits intorm-hull:mainrm-hull/luma.oled:mainfrom
Kihltech:feature/ssd1315Kihltech/luma.oled:feature/ssd1315Copy head branch name to clipboard

Conversation

@Kihltech
Copy link
Copy Markdown
Contributor

@Kihltech Kihltech commented Feb 10, 2026

Changes

Added ssd1315 device class with 128x64 default resolution
Added unit tests and reference data
Added SSD1315 datasheet to documentation
Updated documentation and setup.cfg

Testing

All 5 new tests pass
Tested on physical hardware (Waveshare 0.49" OLED on Raspberry Pi 4B, using width=64, height=32)

Fixes #409

@Kihltech
Add SSD1315 OLED driver support
f706554 
- Add ssd1315 device class with 128x64 default
- Add unit tests and reference data
- Add SSD1315 datasheet
- Update documentation

Fixes rm-hull#409
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Feb 10, 2026

Summary of Changes

Hello @Kihltech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the library's hardware compatibility by integrating support for the SSD1315 OLED display controller. This enhancement allows users to interface with a new range of OLED displays, complete with robust testing and updated project metadata to ensure seamless adoption and functionality.

Highlights

  • New SSD1315 OLED Driver: Introduced a new device class for the SSD1315 OLED display controller, supporting a default resolution of 128x64 pixels.
  • Comprehensive Testing: Added dedicated unit tests and reference data to ensure the correct functionality and display output of the new SSD1315 driver.
  • Documentation and Configuration Updates: Updated the project's README, introduction documentation, and setup configuration to reflect the newly added SSD1315 driver support.
Changelog
  • README.rst
    • Updated the list of supported OLED display drivers to include SSD1315.
  • doc/intro.rst
    • Included SSD1315 in the list of supported OLED controllers in the introduction documentation.
  • luma/oled/device/init.py
    • Added the ssd1315 device class, inheriting from ssd1306, to provide functionality for the new OLED controller.
    • Exported the new ssd1315 class in the module's all list.
  • setup.cfg
    • Modified the project description to list SSD1315 as a supported chipset.
    • Updated project keywords to include 'ssd1315'.
  • tests/reference/data/demo_ssd1315.json
    • Added new JSON reference data specifically for testing the SSD1315 driver's display output.
  • tests/test_ssd1315.py
    • Created a new test file containing unit tests for the ssd1315 driver, covering initialization, display control, and image rendering.
Activity
  • The author, Kihltech, reported that all 5 new tests passed successfully.
  • Physical hardware testing was conducted on a Waveshare 0.49" OLED (64x32) connected to a Raspberry Pi 4B, confirming real-world functionality.
  • This pull request addresses and fixes issue Add SSD1315 OLED driver support #409.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the SSD1315 OLED driver. The changes are well-structured, including updates to documentation, package configuration, and new unit tests. The implementation correctly treats the SSD1315 as a variant of the SSD1306. I have one suggestion to improve code conciseness by removing a redundant __init__ method.

Comment thread luma/oled/device/__init__.py Outdated
@Kihltech
Copy link
Copy Markdown
Contributor Author

Kihltech commented Feb 25, 2026

Is there anything I can do to aid this pull request?

thijstriemstra
thijstriemstra requested changes Feb 25, 2026
View reviewed changes
Comment thread luma/oled/device/__init__.py
@thijstriemstra thijstriemstra mentioned this pull request Feb 25, 2026
Closed
thijstriemstra
thijstriemstra approved these changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately the build is (temporarily) failing due to coveralls.io being down (coverallsapp/github-action#260) but that is unrelated to the code in this PR.

approving this, @rm-hull can you force merge this (skipping the coveralls error) once you approve it?

@rm-hull rm-hull merged commit 81aafca into rm-hull:main Feb 26, 2026
2 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SSD1315 OLED driver support

3 participants

@Kihltech @thijstriemstra @rm-hull
Morty Proxy This is a proxified and sanitized view of the page, visit original site.