Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e10b747

Browse filesBrowse files
committed
Re-retried the object.
It looks like the format has changed a bit since this payload was retrieved originally?
1 parent f2bb6a0 commit e10b747
Copy full SHA for e10b747

File tree

Expand file treeCollapse file tree

2 files changed

+9
-7
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+9
-7
lines changed

‎src/test/java/org/kohsuke/github/GHEventPayloadTest.java

Copy file name to clipboardExpand all lines: src/test/java/org/kohsuke/github/GHEventPayloadTest.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ public void pull_request_review() throws Exception {
193193
GitHub.offline().parseEventPayload(payload.asReader(), GHEventPayload.PullRequestReview.class);
194194
assertThat(event.getAction(), is("submitted"));
195195

196-
assertThat(event.getReview().getId(), is(2626884));
197-
assertThat(event.getReview().getBody(), is("Looks great!"));
196+
assertThat(event.getReview().getId(), is(2626884L));
197+
assertThat(event.getReview().getBody(), is("Looks great!\n"));
198198
assertThat(event.getReview().getState(), is(GHPullRequestReviewState.APPROVED));
199199

200200
assertThat(event.getPullRequest().getNumber(), is(8));

‎src/test/resources/org/kohsuke/github/GHEventPayloadTest/pull_request_review.json

Copy file name to clipboardExpand all lines: src/test/resources/org/kohsuke/github/GHEventPayloadTest/pull_request_review.json
+7-5Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"user": {
66
"login": "baxterthehacker",
77
"id": 6752317,
8-
"avatar_url": "https://avatars.githubusercontent.com/u/6752317?v=3",
8+
"avatar_url": "https://avatars3.githubusercontent.com/u/6752317?v=4",
99
"gravatar_id": "",
1010
"url": "https://api.github.com/users/baxterthehacker",
1111
"html_url": "https://github.com/baxterthehacker",
@@ -21,19 +21,21 @@
2121
"type": "User",
2222
"site_admin": false
2323
},
24-
"body": "Looks great!",
25-
"submitted_at": "2016-10-03T23:39:09Z",
26-
"state": "approved",
24+
"body": "Looks great!\n",
25+
"state": "APPROVED",
2726
"html_url": "https://github.com/baxterthehacker/public-repo/pull/8#pullrequestreview-2626884",
2827
"pull_request_url": "https://api.github.com/repos/baxterthehacker/public-repo/pulls/8",
28+
"author_association": "OWNER",
2929
"_links": {
3030
"html": {
3131
"href": "https://github.com/baxterthehacker/public-repo/pull/8#pullrequestreview-2626884"
3232
},
3333
"pull_request": {
3434
"href": "https://api.github.com/repos/baxterthehacker/public-repo/pulls/8"
3535
}
36-
}
36+
},
37+
"submitted_at": "2016-10-03T23:39:09Z",
38+
"commit_id": "b7a1f9c27caa4e03c14a88feb56e2d4f7500aa63"
3739
},
3840
"pull_request": {
3941
"url": "https://api.github.com/repos/baxterthehacker/public-repo/pulls/8",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.