Adds debug code to reproduce websocket connection timeout issue #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendensoares
added a commit
that referenced
this pull request
Jan 24, 2015
Adds debug code to reproduce websocket connection timeout issue
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced by #843. See its thread for more details.
TODO
Ideally, we want to extend the deadline for each websocket frame, just like thenet/httpserver does, but I'm not sure the best way to accomplish this. It seems the websocketCodecmay be the proper place to do this.The app can extend the deadline for each message received without Revel's help. A sane deadline of 24 hours is set by default for WS requests now.