Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Server engine #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 27, 2017
Merged

Server engine #1165

merged 29 commits into from
Apr 27, 2017

Conversation

notzippy
Copy link
Collaborator

No description provided.

mei-rune and others added 29 commits October 26, 2015 14:26
Expanded BaseTemplate, to carry template name, template path, template type, and filebytes
Moved template detection into engine, and added a BaseEngine class which detects templates by shebang and file extension
# Conflicts:
#	fakeapp_test.go
#	results.go
#	revel.go
#	template.go
#	template_adapter_go.go
…n interface layer to future proof design.

Breaking changes - Anything that hit *http.Request which was bound inside revel.Request, must now use the interface stored in revel.Request.In
Websockets are also changed to user revel.ServerWebsocket.
added SetWriter, WriteStream to ServerResponse
…ed to prevent the results from setting the header and triggering a write. Also in the adapter we cannot use the http.ServerContent method if the output stream is using the compressor.
Added BufferedServerHeader to CompressWriter to prevent header from writing out immediately
Reduced object stack to a single controller stack which has the request and response objects already instaniated in it
Fixed go engine to match new spec
Modified code to make use of the Request object to access the ServerEngine (allows caching of ServerHeader and ResponseWriter)
Modified simple stack to add an upper bounds to the number of objects in cache, any more objects then the upper bounds will be left to garbage collect
@notzippy notzippy merged commit a74d392 into revel:server-engine Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.