-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Server engine #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Server engine #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded BaseTemplate, to carry template name, template path, template type, and filebytes Moved template detection into engine, and added a BaseEngine class which detects templates by shebang and file extension
# Conflicts: # fakeapp_test.go # results.go # revel.go # template.go # template_adapter_go.go
…ookie secretKey if needed
# Conflicts: # results.go # revel.go
…n interface layer to future proof design. Breaking changes - Anything that hit *http.Request which was bound inside revel.Request, must now use the interface stored in revel.Request.In Websockets are also changed to user revel.ServerWebsocket.
added SetWriter, WriteStream to ServerResponse
…ed to prevent the results from setting the header and triggering a write. Also in the adapter we cannot use the http.ServerContent method if the output stream is using the compressor.
Added BufferedServerHeader to CompressWriter to prevent header from writing out immediately Reduced object stack to a single controller stack which has the request and response objects already instaniated in it Fixed go engine to match new spec Modified code to make use of the Request object to access the ServerEngine (allows caching of ServerHeader and ResponseWriter) Modified simple stack to add an upper bounds to the number of objects in cache, any more objects then the upper bounds will be left to garbage collect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.