Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Docs for Float#54

Merged
zth merged 5 commits intorescript-lang:mainrescript-lang/rescript-core:mainfrom
aspeddro:doc-floataspeddro/rescript-core:doc-floatCopy head branch name to clipboard
Feb 24, 2023
Merged

Docs for Float#54
zth merged 5 commits intorescript-lang:mainrescript-lang/rescript-core:mainfrom
aspeddro:doc-floataspeddro/rescript-core:doc-floatCopy head branch name to clipboard

Conversation

@aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Feb 18, 2023

@aspeddro aspeddro marked this pull request as ready for review February 18, 2023 22:26
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! A few comments.

src/Core__Float.resi Show resolved Hide resolved
src/Core__Float.resi Show resolved Hide resolved
src/Core__Float.resi Outdated Show resolved Hide resolved
src/Core__Float.resi Show resolved Hide resolved
@zth zth mentioned this pull request Feb 19, 2023
49 tasks
src/Core__Float.resi Outdated Show resolved Hide resolved
@zth
Copy link
Member

zth commented Feb 24, 2023

@aspeddro this is ready to go, right?

@aspeddro
Copy link
Contributor Author

@aspeddro this is ready to go, right?

yes

Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work!

@zth zth merged commit b5e3e8c into rescript-lang:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.