Array.findLast and other missing functions#126
Open
jmagaram wants to merge 12 commits intorescript-lang:mainrescript-lang/rescript-core:mainfrom
Open
Array.findLast and other missing functions#126jmagaram wants to merge 12 commits intorescript-lang:mainrescript-lang/rescript-core:mainfrom
jmagaram wants to merge 12 commits intorescript-lang:mainrescript-lang/rescript-core:mainfrom
Conversation
Contributor
Author
|
I have no idea why the tests aren't working. It works for me. |
Contributor
|
It fails because the function does not exist in Node.js 16. Node.js 16 is included in the CI matrix because it's a Long Term Support release. It will stop being supported in September, at which point the matrix should be updated and the checks should pass. |
|
Now that Node.js 16 has reached end-of-life, will this be merged for the next release? And thanks, Justin; I needed findLastIndex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some missing functions from the Array module. In particular the
findLastvariants.indexOfFromOpt: add code and docslastIndexOf: docs, testslastIndexOfOpt: testslastIndexOfFrom: docs, testsfindLast: code, docs, testsfindLastIndex: code, docs, testsfindLastIndexOpt: code, docs, testsfindLastIndexWithIndex: code, docs, testsfindLastIndexWithIndexOpt: code, docs