[GIT PULL] net: CurlHttpClient: Call curl_easy_reset() to fix error 'rewinding of the data'#341
Merged
reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom Sep 6, 2025
Merged
[GIT PULL] net: CurlHttpClient: Call curl_easy_reset() to fix error 'rewinding of the data'#341reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
curl_easy_reset() to fix error 'rewinding of the data'#341reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
Conversation
curl_easy_reset() to fix error 'rewindind of the data'curl_easy_reset() to fix error 'rewinding of the data'
reo7sp
requested changes
Sep 6, 2025
e6d14ba to
f295a90
Compare
… of the data' @okman334 reported an error when using the curl HTTP client after commit 775291f ("net: Allow curl handle in CurlHttpClient to be kept alive"): error: curl error: Send failed since rewinding of the data stream failed. Fix this by calling `curl_easy_reset()` before setting curl options. It reinitializes all options previously set on a specified curl handle to the default values while keeping the connection alive. Also, move the timeout options setting below the reset call to avoid losing the timeout options effect. Closes: reo7sp#340 Reported-by: @okman334 Fixes: 775291f ("net: Allow curl handle in CurlHttpClient to be kept alive") Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
f295a90 to
54bc1be
Compare
Contributor
Author
|
Updated. Moved the timeout options setting below the reset call to avoid losing the timeout options effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @reo7sp,
Please consider pulling a single line change to fix a bug in the curl netlib.
@okman334 reported an error when using the curl HTTP client after commit
775291f ("net: Allow curl handle in CurlHttpClient to be kept alive"):
error: curl error: Send failed since rewinding of the data stream failed.
Fix this by calling
curl_easy_reset()before setting curl options. Itreinitializes all options previously set on a specified curl handle to
the default values while keeping the connection alive.
This pull request will close issue #340 once merged.
Thank you!