Make the fields of Telegram types really optional (right now LinkPreviewOptions, ReplyParameters only)#320
Draft
uralm1 wants to merge 3 commits intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
uralm1:optional-fields-sendmessageuralm1/tgbot-cpp:optional-fields-sendmessageCopy head branch name to clipboard
Draft
Make the fields of Telegram types really optional (right now LinkPreviewOptions, ReplyParameters only)#320uralm1 wants to merge 3 commits intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom uralm1:optional-fields-sendmessageuralm1/tgbot-cpp:optional-fields-sendmessageCopy head branch name to clipboard
uralm1 wants to merge 3 commits intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
uralm1:optional-fields-sendmessageuralm1/tgbot-cpp:optional-fields-sendmessageCopy head branch name to clipboard
Conversation
Contributor
|
Code becomes really complicated, tho, wrapping everything in boost optional? |
Author
jsoncpp is promising. |
Contributor
|
sure, i didnt know it was closed, now it is open |
cdfb903 to
d5a2690
Compare
d5a2690 to
42567f5
Compare
w15eacre
reviewed
Nov 17, 2024
|
|
||
| // use for: OptionalPtr<std::shared/unique_ptr<TYPE>> | ||
| // for pointers, we assume optional value == nullptr (or not owned, etc) | ||
| template<typename T> |
There was a problem hiding this comment.
You can specialize the Optional template to create a specific implementation for certain types.
8bdef95 to
d336b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an example approach how to make optional fields of a secondary type classes really optional.
I wrapped optional fields with boost::optional, right now only in LinkPreviewOptions, ReplyParameters classes.
It solves the problem described in issue #308
There are many such classes in Api, so consider this change as an example approach. Any way, it covers most used sendMessage() function, and solves problem with replies.