Avoid unnecessary casting of reply_markup in editMessageText#299
Merged
reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom Mar 26, 2024
Merged
Avoid unnecessary casting of reply_markup in editMessageText#299reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
reo7sp merged 1 commit intoreo7sp:masterreo7sp/tgbot-cpp:masterfrom
Conversation
Owner
|
Thanks👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These change should have been part of #298 PR. I didn't know there was separate method to parse InlineKeyboardMarkup. Upon closer look I noticed editMessageText was calling a generic method which does casting to determine exact keyboard type and then in turn calls another method for parsing the determined type.
Now that we are using inline keyboard specifically, all that is unnecessary. So this one line change bypasses that and its more appropriate.
Sorry for submitting incomplete PR. This should be complete now.