fix(Gradle): Limit Gradle daemon heap size #40090
Open
+155
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f529d4e to
0fe6b7f
Compare
0fe6b7f to
39d9fee
Compare
Author
|
@jamietanna I figured out that the dependency-lockfiles part could run into the same issue, so I went ahead and added a (bigger) heap limit for it as well. I wouldn't expect projects using that feature to run into issues with the change, but if you think we should separate the change, let me know. |
b156363 to
3146bed
Compare
This change introduces a hard-coded heap size for the Gradle daemon used when updating the Gradle wrapper and updating the Gradle dependency lockfile(s). The heap size is limited to 256m for Gradle wrapper updates and 768m for dependency lockfile(s). The higher value for the latter is to give more complex builds a chance to execute. The wrapper update is pretty simple and doesn't need that much heap. Also ensured that the Gradle daemon terminates early by adding a `--no-daemon` for the wrapper-update. Similar for the dependency lockfile(s) added a `--stop` to terminate running daemons, but allow the daemon to stay around and speed up the multiple Gradle invocations. Fixes renovatebot#39558
3146bed to
95e272f
Compare
jamietanna
requested changes
Dec 23, 2025
Contributor
jamietanna
left a comment
There was a problem hiding this comment.
Thanks! Couple of things:
- Adding the
--stopand--no-daemonwould be great as separate changes (i.e. new PR), so they can be released + tested independently, as they should be safe to handle on their own - Via #39558 we should make this configurable, at least for Global config, so it's not defaulted (and i.e. to allow Mend Renovate Enterprise Cloud users to have increased memory allocated, if they wish)
- In the future, we can look at adding repo-level config to tune this
Thanks!
Collaborator
RahulGautamSingh
left a comment
There was a problem hiding this comment.
+1 for making it configurable (at global level)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change introduces a hard-coded heap size for the Gradle daemon used when updating the Gradle wrapper and updating the Gradle dependency lockfile(s).
The heap size is limited to 256m for Gradle wrapper updates and 768m for dependency lockfile(s). The higher value for the latter is to give more complex builds a chance to execute. The wrapper update is pretty simple and doesn't need that much heap.
Also ensured that the Gradle daemon terminates early by adding a
--no-daemonfor the wrapper-update.Similar for the dependency lockfile(s) added a
--stopto terminate running daemons, but allow the daemon to stay around and speed up the multiple Gradle invocations.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: