feat: inherit support for onboardingAutoCloseAge
#40086
Conversation
| logger.debug('Repo is not onboarded and no merged PRs exist'); | ||
| if (!config.suppressNotifications!.includes('onboardingClose')) { | ||
| const ageOfOnboardingPr = getElapsedDays(closedOnboardingPr.createdAt!); | ||
| const onboardingAutoCloseAge = GlobalConfig.get('onboardingAutoCloseAge'); |
There was a problem hiding this comment.
why not still store as variable to have less changes?
| type: 'integer', | ||
| default: null, | ||
| globalOnly: true, | ||
| inheritConfigSupport: true, |
There was a problem hiding this comment.
global only and inherited are somewhat mutually exclusive 🤔
@jamietanna I don't like to mix-up them more than necessary
There was a problem hiding this comment.
Yes I think that's fair - in that case, we'd want only inheritConfigSupport?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
inherited config can contain all repo config options and only some global options, so it makes sense to use both globalOnly and inheritConfigSupport together.
jamietanna
left a comment
There was a problem hiding this comment.
I do wonder if we should make it so the inheritConfig version of the setting should be <= what the global settings are
I.e. so the admin can set onboardingAutoCloseAge=366, and then orgs can do onboardingAutoCloseAge=7 but not onboardingAutoCloseAge=1000
Changes
onboardingAutoCloseAgein inherited config.Context
Please select one of the following:
onboardingAutoCloseAgein inherited config #40011AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: