fix(manager/github-actions): fix regex for docker action matching #39981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix (manager/github-actions): extract docker action when "uses:" is precededed by "-"
viceice
reviewed
Dec 15, 2025
| import { Workflow } from './schema'; | ||
|
|
||
| const dockerActionRe = regEx(/^\s+uses\s*: ['"]?docker:\/\/([^'"\s]+)/); | ||
| const dockerActionRe = regEx(/^\s+-?\s+?uses\s*: ['"]?docker:\/\/([^'"\s]+)/); |
Member
There was a problem hiding this comment.
Suggested change
| const dockerActionRe = regEx(/^\s+-?\s+?uses\s*: ['"]?docker:\/\/([^'"\s]+)/); | |
| const dockerActionRe = regEx(/^\s+(?:-\s+)?uses\s*: ['"]?docker:\/\/([^'"\s]+)/); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix (manager/github-actions): extract docker action when "uses:" is precededed by "-"
Changes
This fixes the regex used for matching docker GithubActions so that it matches when "uses:" is preceded by "-". Related discussion: #39915.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: