feat: add more xtrim method overloads and tests#2010
Merged
PavelPashov merged 1 commit intoredis:mainredis/ioredis:mainfrom Sep 19, 2025
PavelPashov:feature/add-more-xtrim-method-overloadsPavelPashov/ioredis:feature/add-more-xtrim-method-overloadsCopy head branch name to clipboard
Merged
feat: add more xtrim method overloads and tests#2010PavelPashov merged 1 commit intoredis:mainredis/ioredis:mainfrom PavelPashov:feature/add-more-xtrim-method-overloadsPavelPashov/ioredis:feature/add-more-xtrim-method-overloadsCopy head branch name to clipboard
PavelPashov merged 1 commit intoredis:mainredis/ioredis:mainfrom
PavelPashov:feature/add-more-xtrim-method-overloadsPavelPashov/ioredis:feature/add-more-xtrim-method-overloadsCopy head branch name to clipboard
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive method overloads for the xtrim Redis command to support additional options like KEEPREF, DELREF, and ACKED, along with corresponding test coverage. The changes improve the TypeScript interface to better reflect the full Redis XTRIM command syntax.
- Enhanced
xtrimmethod with numerous overloads to support all Redis XTRIM command variations - Added comprehensive test suite covering different parameter combinations
- Updated documentation comment to better describe the command's purpose
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/functional/commands/xtrim.ts | New test file with comprehensive coverage of xtrim command variations |
| lib/utils/RedisCommander.ts | Added extensive method overloads for xtrim with new policy options and updated documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nkaradzhov
approved these changes
Sep 19, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
# [5.8.0](v5.7.0...v5.8.0) (2025-09-23) ### Bug Fixes * **ssubscribe:** re-subscribe sharded pubsub channels individually on ready ([#2012](#2012)) ([55a410f](55a410f)) ### Features * add more xtrim method overloads and tests ([#2010](#2010)) ([8a3e052](8a3e052)) * implement proper hpexpire command signatures and tests ([#2006](#2006)) ([95e80af](95e80af)) * **stream:** Add XDELEX command ([#2003](#2003)) ([7be3c8d](7be3c8d)) * support client setinfo ([#2011](#2011)) ([a5d808b](a5d808b))
|
馃帀 This PR is included in version 5.8.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
simong
added a commit
to simong/ioredis
that referenced
this pull request
Nov 3, 2025
* origin/main: chore(release): 5.8.2 [skip ci] fix: move CLIENT SETINFO commands to connection handshake (redis#2033) ci(test): add redis matrix and update docker compose file (redis#2034) docs(example): add example for setting TTL to "HSET Field" (redis#2027) fix: default IP family selection to 0 (redis#2028) chore(release): 5.8.1 [skip ci] test: add scenario tests v5 (redis#2020) fix(ssubscribe): re-subscribe sharded pubsub channels individually (redis#2021) chore(release): 5.8.0 [skip ci] feat: support client setinfo (redis#2011) feat(stream): Add XDELEX command (redis#2003) Add stale issue management workflow (redis#2018) feat: implement proper hpexpire command signatures and tests (redis#2006) feat: add more xtrim method overloads and tests (redis#2010) test(cluster): fix and add cluster tests in CI (redis#2017) Force slots refresh on MOVED error when using ssubscribe (redis#2013) fix(ssubscribe): re-subscribe sharded pubsub channels individually on ready (redis#2012) chore(release): 5.7.0 [skip ci] fix: xread example for TypeScript (redis#1872) feat: Implement hexpire for redis#1898 (redis#1918)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2009