Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support timeout in Swift#229

Merged
erunion merged 11 commits intoreadmeio:mainreadmeio/httpsnippet:mainfrom
zunda-pixel:support-timeoutzunda-pixel/httpsnippet:support-timeoutCopy head branch name to clipboard
Apr 12, 2024
Merged

Support timeout in Swift#229
erunion merged 11 commits intoreadmeio:mainreadmeio/httpsnippet:mainfrom
zunda-pixel:support-timeoutzunda-pixel/httpsnippet:support-timeoutCopy head branch name to clipboard

Conversation

@zunda-pixel
Copy link

🧰 Changes

  • support timeout paramater
  • remove final newline
  • remove FoundationNetworking
  • remove extra code in multipart/form-data

🧬 QA & Testing

I fixed test code in /httpsnippet/src/targets/swift/urlsession/fixtures/

npm run test

@zunda-pixel zunda-pixel marked this pull request as ready for review April 12, 2024 17:58
@erunion erunion merged commit e3a78da into readmeio:main Apr 12, 2024
@zunda-pixel zunda-pixel deleted the support-timeout branch April 12, 2024 18:17
@erunion
Copy link
Member

erunion commented Apr 12, 2024

Published to 10.0.4!

I'm not sure if you're up for it, or if it's even feasible, but it would be amazing to have Swift as part of our integration test suite.

@zunda-pixel
Copy link
Author

I will try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.