fix(breaking): always return array#225
Merged
erunion merged 1 commit intomainreadmeio/httpsnippet:mainfrom Apr 9, 2024
kanad-2024-04-09/convert-always-returns-arrayreadmeio/httpsnippet:kanad-2024-04-09/convert-always-returns-arrayCopy head branch name to clipboard
Merged
fix(breaking): always return array#225erunion merged 1 commit intomainreadmeio/httpsnippet:mainfrom kanad-2024-04-09/convert-always-returns-arrayreadmeio/httpsnippet:kanad-2024-04-09/convert-always-returns-arrayCopy head branch name to clipboard
erunion merged 1 commit intomainreadmeio/httpsnippet:mainfrom
kanad-2024-04-09/convert-always-returns-arrayreadmeio/httpsnippet:kanad-2024-04-09/convert-always-returns-arrayCopy head branch name to clipboard
Conversation
erunion
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
I had DX concerns about the
string[] | stringsetup in the.convert()method and talked offline with @erunion and agreed that it should always return astring[], so this PR makes that change. This is a breaking change.🧬 QA & Testing
Is this everything? I saw this line below but I think it's unrelated so I left it, but let me know if I'm wrong about this.
httpsnippet/src/targets/index.ts
Line 41 in fc92e40