Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@shjala
Copy link

@shjala shjala commented Aug 20, 2025

I wasn't sure this project accepts PR form outsiders. This is currently WIP, but works fine when I build for web-dev pnpm dev-web. I have tested in with my locally running Kokoro-FastAPI model which implements OpenAI compatible API. The logic is copy-pasted from EdgeTTS. But lacks the following :

  • Configurable endpoint and api key
  • Testing with OpenAI or something else that claims to be OpenAI compatible
  • clean up kokoro specific assumptions

Also for some reason it wont even connect to the TTS engine when I build the macOS application. I'll figure it out.

Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
@shjala shjala marked this pull request as draft August 20, 2025 16:07
@chrox
Copy link
Collaborator

chrox commented Aug 21, 2025

PRs are always welcome, and this looks great! There are a few permission details you may want to check for Tauri builds. With the latest code, tauri http fetch should be able to connect to any endpoint (see default.json#L95). For the built-in window.fetch, you’ll still need to adjust the CSP here: tauri.conf.json#L18.

Ref: https://github.com/readest/readest/blob/main/apps/readest-app/src/services/sync/KOSyncClient.ts#L65

@chrox
Copy link
Collaborator

chrox commented Aug 21, 2025

I’m also planning to implement a BaseHttpTTSClient so that other TTS clients can reuse common code. I’ll likely start working on this next week.

@shjala
Copy link
Author

shjala commented Aug 21, 2025

PRs are always welcome, and this looks great! There are a few permission details you may want to check for Tauri builds. With the latest code, tauri http fetch should be able to connect to any endpoint (see default.json#L95). For the built-in window.fetch, you’ll still need to adjust the CSP here: tauri.conf.json#L18.

Ref: https://github.com/readest/readest/blob/main/apps/readest-app/src/services/sync/KOSyncClient.ts#L65

Awesome! and thanks for the pointers, I will test it this afternoon. Also for setting the endpoint and API key, do you have any preference in terms of which menu?

@priyalthemacrosoft
Copy link

@shjala, could you let me know if you resolved the PR issue?

@chrox
Copy link
Collaborator

chrox commented Sep 15, 2025

Also for setting the endpoint and API key, do you have any preference in terms of which menu?

The Settings - Custom dialog is a good place for setting the API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.