Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

decim92
Copy link
Contributor

@decim92 decim92 commented Aug 30, 2024

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the main branch, NOT a "stable" branch.

Motivation (required)

After installing version 7.1.2, when I run the iOS project it won't compile since it complains of undefined classes
It is related to this issue #2318

What existing problem does the pull request solve?
It compiles the iOS project in latest version

Test Plan (required)

I don't know how you make it work in your environment but if these frameworks are missing it won't work

@Johan-dutoit
Copy link
Collaborator

Johan-dutoit commented Nov 28, 2024

Interestingly, the example app (freshly created) builds fine when using the latest image picker.
Don't immediately seem harm making this change though.

@Johan-dutoit Johan-dutoit merged commit 20c3d92 into react-native-image-picker:main Nov 28, 2024
Johan-dutoit pushed a commit that referenced this pull request Nov 28, 2024
## [7.1.4](v7.1.3...v7.1.4) (2024-11-28)

### Bug Fixes

* **ios:** missing required frameworks ([#2320](#2320)) ([20c3d92](20c3d92))
@Johan-dutoit
Copy link
Collaborator

🎉 This PR is included in version 7.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Cactueonicle added a commit to Cactueonicle/improvements that referenced this pull request Aug 13, 2025
TideTrackerDev added a commit to TideTrackerDev/convexification that referenced this pull request Aug 25, 2025
MarlowerThorne added a commit to MarlowerThorne/congenia that referenced this pull request Sep 17, 2025
AsasReed added a commit to AsasReed/friened that referenced this pull request Sep 18, 2025
gngseb added a commit to gngseb/Nemeth that referenced this pull request Oct 7, 2025
iceVeges added a commit to iceVeges/uws4vad that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.