Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TextElement - defaultProps were removed in ver 3.x #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
Loading
from

Conversation

chenop
Copy link

@chenop chenop commented Sep 28, 2024

What kind of change does this PR introduce?

For version 3.x remove defaultProps from TextElement

Did you add tests for your changes?
No - just made sure "yarn test" is still green

If relevant, did you update the documentation?
No

Summary

When using the CheckBox component got the following error:
Warning: TextElement: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead

https://github.com/react-native-elements/react-native-elements/pull/3942/files

Does this PR introduce a breaking change?
No

Other information
Version 3.4.3

@malika-k
Copy link

This may be a solution to the bug I've filed: #3963

Is a reason why this has not been merged?

@chenop
Copy link
Author

chenop commented Feb 26, 2025

This may be a solution to the bug I've filed: #3963

Is a reason why this has not been merged?

Unfortunately, this project was abandoned in July 2023 (last release).

@zabojad
Copy link

zabojad commented Mar 10, 2025

We are having the same issue with the Slider component...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.