fix: add react 19 as peer dependency #1422
Conversation
|
@rolandjitsu would it be possible to have this merged soon? |
|
Can you do merge this soon please ? |
There was a problem hiding this comment.
I... don't think this PR solves any issue? The current semver range for react-dropzone is >= 16.8 || 18.0.0... which may have been written in error, since it simplifies to just >= 16.8 (that is, a constraint satisfiable by any React version equal to or above 16.8, including React 17, React 19, etc.).
Expanding this further to >= 16.8 || 18.0.0 || 19.0.0 as this PR does has no impact whatsoever. It will not fix any issues. Check for yourself here:
I haven't even tried to install react-dropzone yet; I was just checking most upvoted open issues to see if this library was maintained enough to use (which unfortunately might not be the case?), so take this with a grain of salt, but offhand without looking more closely I'd assume @Philipp91's PR #1407 is closer to fixing the underlying issue. It would probably just need to change the React peer dependency version to ~19.0.0 and add a semver-major bump to react-dropzone itself, since I assume the typings change is backwards-incompatible.
EDIT: I see #1410 was already merged and released, which obviates #1407 as well -- perhaps this library is working after all as of the latest release and this PR as well as #1400 can be closed?
|
hello @rolandjitsu have you some news regarding this PR ? |
|
Have you any update on this PR @rolandjitsu ? |
|
Hi folks, just repeating again that this PR does nothing. It won't help with any issues you're experiencing around React version mismatch. I'll be unsubscribing from this issue now, but for anyone still struggling, you can try checking whether you're on the latest react-dropzone point release (you can check with |
| "license": "MIT", | ||
| "peerDependencies": { | ||
| "react": ">= 16.8 || 18.0.0" | ||
| "react": ">= 16.8 || 18.0.0 || 19.0.0" |
There was a problem hiding this comment.
We should probably make this a bit more verbose
| "react": ">= 16.8 || 18.0.0 || 19.0.0" | |
| "react": ">= 17.x || 18.x || 19.x" |
Setting semver range w/ full major, patch, minor tells the package manager that even w/ the >= it expects it to be 19.0.0
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Explain the motivation for making this change. What existing problem does the pull request solve?
Try to link to an open issue for more information.
Solves #1400 . Updates peer dependency package range to support react 19.
Does this PR introduce a breaking change?
If this PR introduces a breaking change, please describe the impact and a migration path for existing applications.
N/A
Other information
N/A