feat: add human-readable file size formatting to error messages #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fc122b to
148f185
Compare
rolandjitsu
requested changes
Oct 2, 2024
| }; | ||
|
|
||
| export const getTooLargeRejectionErr = (maxSize) => { | ||
| export const getTooLargeRejectionErr = (maxSizeInBytes) => { |
There was a problem hiding this comment.
Please add a unit test for this.
|
|
||
| export const getTooLargeRejectionErr = (maxSize) => { | ||
| export const getTooLargeRejectionErr = (maxSizeInBytes) => { | ||
| const units = ["B", "KB", "MB", "GB", "TB"]; |
There was a problem hiding this comment.
This could live outside the func.
|
@issambaccouch let me know if you can make the requested changes. Also note there's #1304 which is related to your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
This pull request addresses the need for user-friendly error messages
Does this PR introduce a breaking change?
No
Other information