Fixed params to be set when mounted after resize events #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld return an empty object until the next resize event after mounting occurred.
d6u
reviewed
Mar 14, 2018
| this._processSize({ | ||
| width: this._getNumber(styles.width), | ||
| height: this._getNumber(styles.height), | ||
| }); |
There was a problem hiding this comment.
Sorry for the late reply.
Hmm, this is interesting. I don't fully understand. I have to investigate a bit. I thought once observe is called, the callback registered with ResizeObserverLite will be triggered immediately. But look like it's not.
There was a problem hiding this comment.
Yeah. It is interesting. I didn't look into ResizeObserverLite to see if there is a problem in there. I just assumed that if all the resize events were finished by the time the component was mounted then ResizeObserverLite would have no trigger to fire it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to set params when observing an element, otherwise params would return an empty object until the next resize event after mounting occurred.
I've also added a test for this case. Before my changes this test would fail with