Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

LinkContainer turns all children's tags into a's. #261

Copy link
Copy link
@dennisoelkers

Description

@dennisoelkers
Issue body actions

We are currently upgrading from react-router v3 to v5, therefore also upgrading react-router-bootstrap from v0.23.3 to v0.25.0. We have noticed that LinkContainer (which is just wrapping Route) is turning all children into a-tags, even though e.g. a Button component is passed.

Is this on purpose? Is there any way around this?

Right now it is breaking our tests (we are assuming e.g. that a button component is used in some places).

dloewen and stefanostojicstefanostojic

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.