Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: add struct tags and update docs#477

Merged
ravisuhag merged 3 commits intomainraystack/meteor:mainfrom
update-extractorsraystack/meteor:update-extractorsCopy head branch name to clipboard
Mar 22, 2023
Merged

chore: add struct tags and update docs#477
ravisuhag merged 3 commits intomainraystack/meteor:mainfrom
update-extractorsraystack/meteor:update-extractorsCopy head branch name to clipboard

Conversation

@Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Mar 15, 2023

Updating README for following plugins:

@Chief-Rishab Chief-Rishab requested a review from kushsharma March 15, 2023 13:58
@Chief-Rishab Chief-Rishab changed the title docs: update README for plugins chore: add struct tags and update docs Mar 15, 2023
@kushsharma
Copy link
Member

Extra yaml/json struct tags look alright but I do see a few extra changes like tableu identifier, what are these for?

plugins/extractors/tableau/tableau.go Show resolved Hide resolved
plugins/sinks/compass/README.md Show resolved Hide resolved
test/e2e/mysql_kafka.yml Show resolved Hide resolved
@kushsharma
Copy link
Member

LGTM

@ravisuhag ravisuhag merged commit 4c18210 into main Mar 22, 2023
@ravisuhag ravisuhag deleted the update-extractors branch March 22, 2023 17:35
@ravisuhag ravisuhag linked an issue Mar 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update README.md for labels for compass sink

3 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.