Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: docker compose for dagger quickstart#206

Merged
Meghajit merged 31 commits intomainraystack/dagger:mainfrom
docker-composeraystack/dagger:docker-composeCopy head branch name to clipboard
Oct 31, 2022
Merged

feat: docker compose for dagger quickstart#206
Meghajit merged 31 commits intomainraystack/dagger:mainfrom
docker-composeraystack/dagger:docker-composeCopy head branch name to clipboard

Conversation

@sumitaich1998
Copy link
Contributor

@sumitaich1998 sumitaich1998 commented Oct 20, 2022 •
edited
Loading

fixes #207

Acceptance Criteria:

GIVEN WHEN THEN
Jack is a new user who wants to try out Dagger locally quickly, AND,Jack doesn’t want to do any complex installation of dependencies like Kafka or Apache Flink locally Jack runs the Docker Compose file by executing docker compose up in the directory containing the docker compose file Run Dagger jar in a containerA local kafka cluster should be setup with just one broker containerA kafka producer container should be spawned which continuosly produces messages to some source Kafka topicA bare minimum dagger job with just a 30 sec aggregateSQL query should get submitted to the local Flink cluster with both source and sink as KafkaThe dagger should continue to consume messages from the source topic and publish messages to the sink topic until Jack explicitly executes docker compose down
Jack is a new user who wants to try out Dagger locally quickly, AND,Jack doesn’t want to do any complex installation of dependencies like Kafka or Apache Flink locally Jack runs the Docker Compose file by executing docker compose down in the directory containing the docker compose file All the spawned containers: Dagger, Kafka, etc should be closed down gracefully.

@sumitaich1998 sumitaich1998 self-assigned this Oct 20, 2022
@sumitaich1998 sumitaich1998 marked this pull request as ready for review October 20, 2022 13:00
kevinbheda
kevinbheda reviewed Oct 26, 2022
View reviewed changes
quickstart-docker/compose.yaml Show resolved Hide resolved
quickstart-docker/resources/sample_message.txt Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Show resolved Hide resolved
kevinbheda
kevinbheda reviewed Oct 26, 2022
View reviewed changes
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
@Meghajit
Copy link
Member

Meghajit commented Oct 26, 2022 •
edited
Loading

@sumitaich1998 Some feedback:

  1. Let's name the topmost folder as quickstart instead of quickstart-docker.
    This folder will house other resources as well in the future stories and not just the docker compose file. We can create a nested folder called as docker-compose and place the related files inside

  2. I think this was missed in the ACs. But we would need to link this docker compose setup in the documentation. Can you mention a link to this file in: the landing page README here + in the quickstart documentation here

Meghajit
Meghajit reviewed Oct 26, 2022
View reviewed changes
quickstart-docker/resources/local.properties Outdated Show resolved Hide resolved
quickstart-docker/resources/TestMessage.proto Outdated Show resolved Hide resolved
quickstart-docker/resources/TestLogMessage.proto Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Show resolved Hide resolved
quickstart-docker/compose.yaml Show resolved Hide resolved
kevinbheda
kevinbheda reviewed Oct 26, 2022
View reviewed changes
quickstart-docker/compose.yaml Outdated
Copy link
Contributor

@kevinbheda kevinbheda Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit version of kafkacat need to be installed to maintain compatiblity

Copy link
Contributor Author

@sumitaich1998 sumitaich1998 Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

quickstart-docker/resources/kafkafeeder.sh Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dagger ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 10:55AM (UTC)

Meghajit
Meghajit reviewed Oct 31, 2022
View reviewed changes
quickstart/docker-compose/compose.yaml Outdated Show resolved Hide resolved
Meghajit
Meghajit reviewed Oct 31, 2022
View reviewed changes
docs/docs/guides/quickstart.md Outdated Show resolved Hide resolved
@Meghajit Meghajit merged commit 3cd94c4 into main Oct 31, 2022
@Meghajit Meghajit deleted the docker-compose branch October 31, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinbheda kevinbheda kevinbheda left review comments

@Meghajit Meghajit Meghajit left review comments

Assignees

@sumitaich1998 sumitaich1998

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker compose setup for dagger quickstart

3 participants

@sumitaich1998 @Meghajit @kevinbheda

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.