Fix cups usage by using correct request class name in CupsRequestor #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice KOEHL <fabrice.koehl@schiller.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?
I need this library to direct print from my Laravel app with cups.
I did not create an issue first, should I do so? (sorry this is my first pull request).
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)
No written test, but I did test with this line, and it works:
Printing::newPrintTask()->printer("ipp://localhost:631/printers/MY_PRINTER")->file('MY_FILE.pdf')->send()4️⃣ Please include a thorough description of the improvement and reasons why it's useful.
I fixed the class name in
CupsRequestor:HttpRequestinstead ofPendingRequest5️⃣ Thanks for contributing! 🙌