This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Remove LogTooLongException#49
Merged
StephenHynes7 merged 8 commits intorapid7:masterrapid7/le_java:masterfrom Jun 24, 2016
omgapuppy:masterCopy head branch name to clipboard
Merged
Remove LogTooLongException#49StephenHynes7 merged 8 commits intorapid7:masterrapid7/le_java:masterfrom omgapuppy:masterCopy head branch name to clipboard
StephenHynes7 merged 8 commits intorapid7:masterrapid7/le_java:masterfrom
omgapuppy:masterCopy head branch name to clipboard
Conversation
Remove uncaught exception, write a test case, fail silently like other libraries
Contributor
|
@m0wfo thoughts? I am okay with this as a temp fix while we fix the logic for big stack traces. |
|
|
||
| private void addLineToQueue (String line, int limit) { | ||
| if (limit == 0) { throw new LogTooLongException(); } | ||
| if (limit == 0) { return; } |
There was a problem hiding this comment.
maybe add a dbg() statement saying 'message too long' or something in addition to returning
|
+1 when Travis is happy |
|
build failure seems to have something to do with the forked JVM not shutting down when using openjdk - don't think it's anything to do with my changes |
Contributor
|
@ardimehist-r7 that is horrible but yey, I guess :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove uncaught exception, write a test case, fail silently like other
libraries