Implemented the Main SyncLoop and Static Pod Support #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new daemon mode that continuously monitors a static pod configuration directory and synchronizes pod states using a main sync loop. Key changes include:
- Adding Clone derivations and refactoring file-based task initialization in task.rs.
- Introducing a daemon command in main.rs to run the sync loop.
- Creating new daemon modules (sync_loop and static_pods) to support periodic static pod checking.
- Updating cli_commands to integrate the new task runner functionality.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| project/rkl/src/task.rs | Adds Clone to key structs and refactors task initialization methods. |
| project/rkl/src/main.rs | Introduces the Daemon command and initializes tracing for logging. |
| project/rkl/src/lib.rs | Exposes the new daemon module. |
| project/rkl/src/daemon/sync_loop.rs | Implements the main sync loop and event registration. |
| project/rkl/src/daemon/static_pods.rs | Implements static pod checking and synchronization logic. |
| project/rkl/src/cli_commands.rs | Adjusts pod startup functions to use the new task runner setup. |
| @@ -38,9 +38,13 @@ enum Commands { | ||
| pod_name: String, | ||
| }, | ||
| Exec(Box<rkl::commands::exec_cli::Exec>), | ||
| // Run as a daemon process. | ||
| // For convenient, I won't remove cli part now. |
There was a problem hiding this comment.
[nitpick] Review the inline comment regarding retaining the CLI code for daemon execution; consider clarifying its intent or removing it for production clarity.
Suggested change
| // For convenient, I won't remove cli part now. | |
| // The Daemon command is retained in the CLI for development and testing purposes. |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
genedna
reviewed
May 1, 2025
…undle path Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
…ove tracing Signed-off-by: acfboy <acfboyu@outlook.com>
…countering a network creation error during pod creation. Signed-off-by: acfboy <acfboyu@outlook.com>
Signed-off-by: acfboy <acfboyu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现了部分 #71 中的功能。顺便修复了原先创建网络失败时没有正确错误处理（删除创建的容器）的 bug。
做了的：
/etc/rk8s/manifests目录下的 pod 配置文件和当前运行的 pod 情况是否一致，并使运行的 pod 和目录下的配置保持一致。还没做，将要做的：