Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

junit: strip ANSI escapes from message as well? #2032

Copy link
Copy link
@kevinushey

Description

@kevinushey
Issue body actions

E.g. here:

testthat/R/reporter-junit.R

Lines 116 to 119 in 886527d

first_line <- function(x) {
loc <- expectation_location(x, " (", ")")
paste0(strsplit(x$message, split = "\n")[[1]][1], loc)
}

Note that testthat is already stripping ANSI escapes for the regular message bodies.

xml2::xml_text(error) <- cli::ansi_strip(format(result))

Presumably because control characters aren't normally allowed in XML (well, XML 1.0) files?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.