Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

HTML Reporter: Fix <label> to wrap <select> for multi-value urlConfig item #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Krinkle merged 1 commit into from
Jul 3, 2024
Merged

HTML Reporter: Fix <label> to wrap <select> for multi-value urlConfig item #1773

Krinkle merged 1 commit into from
Jul 3, 2024

Conversation

@Krinkle
Copy link
Member

@Krinkle Krinkle commented Jul 2, 2024

https://qunitjs.com/api/config/urlConfig/

Demonstrated by http://localhost:4000/test/reporter-urlparams.html fixture.

This creates consistency with how we render label/input checkboxes, and improves spacing in the design.

Before (top), After (bottom).

Screenshot 2024-07-02 at 20 31 35

@Krinkle Krinkle closed this Jul 3, 2024
@Krinkle Krinkle deleted the html-reporter-select-label branch July 3, 2024 00:14
@Krinkle Krinkle restored the html-reporter-select-label branch July 3, 2024 00:15
@Krinkle Krinkle reopened this Jul 3, 2024
@Krinkle Krinkle merged commit 80a1695 into qunitjs:main Jul 3, 2024
@Krinkle Krinkle deleted the html-reporter-select-label branch July 3, 2024 00:20
Krinkle added a commit that referenced this pull request Dec 5, 2024
@Krinkle
HTML Reporter: Fix <label> to wrap <select> for multi-value urlCo…
f78da46 
…nfig item

Cherry-picked from 80a1695 (3.0.0-dev):
> Details and screenshot at #1773.

Also includes a partial cherry-pick from 57c2dbc to improve the
`test/reporter-urlparams.js` file with a menu case, to ease manual
testing of this behavior.
@Krinkle Krinkle added this to the 2.x release milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

2.x release

Development

Successfully merging this pull request may close these issues.

1 participant

@Krinkle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.