Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

Hi, we upgraded quickfix from 0.6.0 to 0.7.0 and seeing that calling Stop on the initiator hangs the second time.
Our app has a single initiator which we use for the entire app lifecycle, when we get a goodnight message we stop the initiator and then call Start when the new day starts.
So this worked with 0.6.0 but hangs with 0.7.0 at the end of the second day.

We tracked this break to this PR, session.Stop is basically ignored on the second time, and we hang here:

wg.Wait()

This is because the session is not stopped and stays running.

It's unclear to me whether this is a bug, or if we're not utilizing the initiator correctly and the break is intentional? Are we only supposed to call Start/Stop once and recreate it each time?

cc @ackleymi @shipa998

You must be logged in to vote

Replies: 3 comments · 1 reply

Comment options

@ackleymi really need guidance here, tried recreating the initiator after stopping it but that's giving me a duplicate session id error so it's really not clear what's the proper way to do this with library now? Thanks.

You must be logged in to vote
0 replies
Comment options

I am on v0.9.0 and facing the exact same issue,
initial start and stop works. But after this state calling start causes Duplicate SessionID error, after this error calling stop causes it to hang forever.

You must be logged in to vote
0 replies
Comment options

I'm on the latest version v0.9.4 and also running into this issue. After the initiator has been stopped once and restarted, the second call to Stop hangs forever.

You must be logged in to vote
1 reply
@claytn
Comment options

It seems like the best course of action here is to create a new initiator instance after each Stop call. In one of the more recent changes here, sessions are unregistered after Stop is called which means you can recreate a new initiator instance with the same quickfix settings as your first instance (just makes things more convenient).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.