php 8 and phpunit 9.5 Support#2
Merged
makasim merged 1 commit intoqueue-interop:masterqueue-interop/queue-spec:masterfrom Dec 30, 2020
adspons:masterCopy head branch name to clipboard
Merged
php 8 and phpunit 9.5 Support#2makasim merged 1 commit intoqueue-interop:masterqueue-interop/queue-spec:masterfrom adspons:masterCopy head branch name to clipboard
makasim merged 1 commit intoqueue-interop:masterqueue-interop/queue-spec:masterfrom
adspons:masterCopy head branch name to clipboard
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just updated return typehints of tearDown methods so they now compatible with phpunit 9.5 which allows to use this package on projects with php 8 onboard as well as needed to proceed with enqueue update: php-enqueue/enqueue-dev#1121