Add EfficientNet encoder #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
reviewed
Oct 2, 2019
| from efficientnet_pytorch.utils import relu_fn, url_map, get_model_params | ||
| import torch.nn as nn | ||
| import torch | ||
| import segmentation_models_pytorch as smp |
There was a problem hiding this comment.
Why do we need this import?
There was a problem hiding this comment.
Just forgot to remove it after porting this code from my "external" implementation :) Fixed.
qubvel
reviewed
Oct 2, 2019
Comment on lines
44
to
47
| 'imagenet': { | ||
| 'mean': [0.485, 0.456, 0.406], | ||
| 'std': [0.229, 0.224, 0.225], | ||
| 'url': url_map[encoder] |
There was a problem hiding this comment.
Please, add here:
'input_space': 'RGB',
'input_range': [0, 1],
29c053c to
d92d526
Compare
|
Great! Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Added EfficientNet encoder from here https://github.com/lukemelas/EfficientNet-PyTorch/tree/master/efficientnet_pytorch
Let me know if any changes needed.