Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Minor fixes for Python3 and more #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlanJAS wants to merge 3 commits into from
Closed

Minor fixes for Python3 and more #501

AlanJAS wants to merge 3 commits into from

Conversation

@AlanJAS
Copy link
Contributor

@AlanJAS AlanJAS commented Feb 8, 2024

Small fixes

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Feb 8, 2024

Thanks!

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Feb 8, 2024

Actually, can you please adjust the commit messages so they match our style (<module|subject|"tree">: summary) so I can rebase-merge them, preserving your individual commits (thanks!) while maintaining a simple and linear history?

Something along the lines of:

core: remove inheritance from object, implicit in python3
openusb: fix missing commas in __all__ list
libusb1: fix trailing comma in LIBUSB_TRANSFER_TYPE_CONTROL

(These also include some changes in the summaries, which I think make them a tiny bit clearer [to me], but your summaries were very good as well. Please feel free to keep them, if you like them better).

jonasmalacofilho pushed a commit that referenced this pull request Feb 11, 2024
@AlanJAS @jonasmalacofilho
core: remove inheritance from object, implicit in python3 (#501)
d71cadf
jonasmalacofilho pushed a commit that referenced this pull request Feb 11, 2024
@AlanJAS @jonasmalacofilho
openusb: fix missing commas in __all__ list (#501)
9ba82b4
jonasmalacofilho pushed a commit that referenced this pull request Feb 11, 2024
@AlanJAS @jonasmalacofilho
libusb1: fix trailing comma in LIBUSB_TRANSFER_TYPE_CONTROL (#501)
8205fc3
@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Feb 11, 2024

Applied with adjusted commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasmalacofilho jonasmalacofilho jonasmalacofilho approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlanJAS @jonasmalacofilho @mcuee
Morty Proxy This is a proxified and sanitized view of the page, visit original site.