update target network weight during episode after x timesteps#2110
Merged
svekars merged 2 commits intopytorch:masterpytorch/tutorials:masterfrom Nov 8, 2022
Mdhvince:mdhvince/q_target-not-fixed-during-episodeMdhvince/tutorials:mdhvince/q_target-not-fixed-during-episodeCopy head branch name to clipboard
Merged
update target network weight during episode after x timesteps#2110svekars merged 2 commits intopytorch:masterpytorch/tutorials:masterfrom Mdhvince:mdhvince/q_target-not-fixed-during-episodeMdhvince/tutorials:mdhvince/q_target-not-fixed-during-episodeCopy head branch name to clipboard
svekars merged 2 commits intopytorch:masterpytorch/tutorials:masterfrom
Mdhvince:mdhvince/q_target-not-fixed-during-episodeMdhvince/tutorials:mdhvince/q_target-not-fixed-during-episodeCopy head branch name to clipboard
Conversation
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vmoens
approved these changes
Nov 3, 2022
Contributor
vmoens
left a comment
There was a problem hiding this comment.
LGTM thanks for spotting this!
Contributor
Author
|
You welcome, thanks to you 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the target network remain fixed during the entire episode.
In this PR I have moved the update of the weigths inside the inner loop of the training. So the update can occure during the episode.
Without this change, if the episode is too long, the target network will be too different from the behavior network.
cc @vmoens @nairbv