Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[inductor][invoke_subgraph] Mark invoke_subgraph outputs as user_visible to constrain output strides #155395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: gh/anijain2305/788/base
Choose a base branch
Loading
from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Jun 7, 2025

…ble to constrain output strides

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155395

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 04b4286 with merge base 8153340 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Jun 7, 2025
…ble to constrain output strides

ghstack-source-id: df83517
Pull Request resolved: #155395
…s user_visible to constrain output strides"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 7, 2025
…ble to constrain output strides

ghstack-source-id: 99a532e
Pull Request resolved: #155395
@anijain2305
Copy link
Contributor Author

cc @eellison @zou3519 What would be a good test for this? I tried a few options, but I am unable to write one out.

…s user_visible to constrain output strides"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 8, 2025
…ble to constrain output strides

ghstack-source-id: 9a907cd
Pull Request resolved: #155395
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 9, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 9, 2025
…ble to constrain output strides

ghstack-source-id: 3c60cab
Pull Request resolved: #155395
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 9, 2025
…ble to constrain output strides

ghstack-source-id: 1378966
Pull Request resolved: #155395
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 9, 2025
…ble to constrain output strides

ghstack-source-id: 3e0ad90
Pull Request resolved: #155395
@anijain2305 anijain2305 requested review from zou3519 and eellison June 9, 2025 21:18
anijain2305 added a commit that referenced this pull request Jun 9, 2025
…ble to constrain output strides

ghstack-source-id: 3e0ad90
Pull Request resolved: #155395
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 9, 2025
…ble to constrain output strides

ghstack-source-id: d0b67f9
Pull Request resolved: #155395
@anijain2305
Copy link
Contributor Author

Added the test, but I am unable to make it fail in the absence of this PR. In the absence of this PR, we just end up having a kernel that strides the output of the invoke_subgraph to the custom op.

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Jun 10, 2025
…ble to constrain output strides

ghstack-source-id: 2fc1b47
Pull Request resolved: #155395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: inductor topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.