Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[nativert] Move Weights to PyTorch core #155156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yiming0416
Copy link
Contributor

Summary:
Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Differential Revision: D75973156

Copy link

pytorch-bot bot commented Jun 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155156

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 62a1678 with merge base 2908c10 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

@yiming0416 yiming0416 marked this pull request as draft June 4, 2025 21:17
@yiming0416 yiming0416 added the topic: not user facing topic category label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request Jun 4, 2025
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Differential Revision: D75973156
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request Jun 5, 2025
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Differential Revision: D75973156
@yiming0416 yiming0416 marked this pull request as ready for review June 5, 2025 15:52
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request Jun 6, 2025
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Reviewed By: zhxchen17

Differential Revision: D75973156
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request Jun 6, 2025
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Reviewed By: zhxchen17

Differential Revision: D75973156
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request Jun 6, 2025
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan:
```
buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test
```

Reviewed By: zhxchen17

Differential Revision: D75973156
Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan:
```
buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test
```

Reviewed By: zhxchen17

Differential Revision: D75973156
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75973156

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable), pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.