[nativert] Move Weights to PyTorch core #155156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155156
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 62a1678 with merge base 2908c10 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
aa50774 to
2ff5105
Compare
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test Differential Revision: D75973156
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
2ff5105 to
d110bb3
Compare
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Jun 5, 2025
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test Differential Revision: D75973156
zhxchen17
approved these changes
Jun 5, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test Reviewed By: zhxchen17 Differential Revision: D75973156
d110bb3 to
d02270a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test Reviewed By: zhxchen17 Differential Revision: D75973156
d02270a to
a8d34c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
a8d34c2 to
ae30a1c
Compare
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: ``` buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test ``` Reviewed By: zhxchen17 Differential Revision: D75973156
Summary: Pull Request resolved: pytorch#155156 Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: ``` buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test ``` Reviewed By: zhxchen17 Differential Revision: D75973156
|
This pull request was exported from Phabricator. Differential Revision: D75973156 |
ae30a1c to
62a1678
Compare
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable), pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
thatgeeman
pushed a commit
to thatgeeman/pytorch-docathon
that referenced
this pull request
Jun 15, 2025
Summary: Moves Weights class to PyTorch core Torch Native Runtime RFC: pytorch/rfcs#72 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test Differential Revision: D75973156 Pull Request resolved: pytorch#155156 Approved by: https://github.com/zhxchen17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md
Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test
Differential Revision: D75973156