Handle aten.to at submodule boundaries #153972
Open
+189
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153972
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 Pending, 2 Unrelated FailuresAs of commit e1dc1e3 with merge base eba5fc9 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
d9fdfee to
8316569
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 20, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
8316569 to
5456ca0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
5456ca0 to
c01f843
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
c01f843 to
3bed9ae
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
3bed9ae to
5739e31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Differential Revision: D74582970
5739e31 to
1be3847
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
1be3847 to
b39b791
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Differential Revision: D74582970
66da888 to
08f7244
Compare
avikchaudhuri
approved these changes
May 22, 2025
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
08f7244 to
fd18a7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
fd18a7c to
24e4ddd
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
24e4ddd to
7656bc0
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
7656bc0 to
c67797f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
c67797f to
a3047ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
a3047ca to
89c8fdf
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
May 22, 2025
Summary: #buildall Test Plan: CI Reviewed By: avikchaudhuri Differential Revision: D74582970
89c8fdf to
b013341
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
b013341 to
c2c384e
Compare
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Jun 9, 2025
Summary: #buildall Test Plan: CI Reviewed By: SherlockNoMad, avikchaudhuri Differential Revision: D74582970
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Jun 9, 2025
Summary: #buildall Test Plan: CI Reviewed By: SherlockNoMad, avikchaudhuri Differential Revision: D74582970
c2c384e to
664a4c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
Summary: #buildall Test Plan: CI Reviewed By: SherlockNoMad, avikchaudhuri Differential Revision: D74582970
664a4c5 to
e1dc1e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #buildall
Test Plan: CI
Differential Revision: D74582970
When we decompose to inference IR, aten.to can sometimes disappear. As a result, export module call graph tree will start containing dead nodes because previous provenance tracking is insufficient. This PR fixes that. The caveat is that this won't work in general for tensor subclass inputs to submodule that user wants to preserve signature because we always desugar the tensor subclass into constituent tensors in inference IR making it impossible to preserve the original calling convention.
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv