Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ci: Remove manylinux 2014 remnants #148028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

ci: Remove manylinux 2014 remnants #148028

wants to merge 4 commits into from

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Feb 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

Tip

I checked if we were using these by running
rg 2014 .github/

Signed-off-by: Eli Uriegas eliuriegas@meta.com

@seemethere
Update
f5df36f 
[ghstack-poisoned]
@seemethere seemethere requested review from a team and jeffdaily as code owners February 27, 2025 00:25
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148028

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Cancelled Jobs, 1 Pending

As of commit 481a862 with merge base 723f3a9 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 27, 2025
seemethere added a commit that referenced this pull request Feb 27, 2025
@seemethere
ci: Remove manylinux 2014 remnants
6201b6e 
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

ghstack-source-id: aff93fd
Pull Request resolved: #148028
@seemethere
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 6 jobs have failed, first few of them are: Build Triton wheels / Build Triton Wheel (3.9, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.10, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.11, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.12, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.13, cuda, pytorch/manylinux-builder:cpu)

Details for Dev Infra team Raised by workflow job

huydhn
huydhn reviewed Feb 27, 2025
View reviewed changes
.github/workflows/build-triton-wheel.yml Outdated
@@ -62,7 +62,7 @@ jobs:
DOCKER_IMAGE: ${{ matrix.device == 'rocm' && format('pytorch/manylinux2_28-builder:rocm{0}', matrix.rocm_version) || matrix.docker-image }}
PY_VERS: ${{ matrix.py_vers }}
BUILD_DEVICE: ${{ matrix.device }}
PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' || 'manylinux2014_x86_64' }}
PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' }}
Copy link
Contributor

@huydhn huydhn Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turns PLATFORM into a boolean false when the docker image doesn't contain 2_28 and fails the build, i.e. https://github.com/pytorch/pytorch/actions/runs/13556101092/job/37890623418

Suggested change
PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' }}
PLATFORM: 'manylinux_2_28_x86_64'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pytorch/manylinux-builder:cpu on line 49 would also need to be removed

atalman
atalman approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you.

@seemethere
Update
c4c4570 
[ghstack-poisoned]
seemethere added a commit that referenced this pull request Feb 27, 2025
@seemethere
ci: Remove manylinux 2014 remnants
6eaf8bd 
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

ghstack-source-id: 159a5e5
Pull Request resolved: #148028

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Copy link
Member Author

@atalman Can I ignore the Triton wheel build failures? It looks like the wheel failures are for the old version of manylinux that we don't support anymore

@seemethere
Update
a0651b4 
[ghstack-poisoned]
seemethere added a commit that referenced this pull request Feb 27, 2025
@seemethere
ci: Remove manylinux 2014 remnants
3f96d06 
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

ghstack-source-id: 0950613
Pull Request resolved: #148028

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Update
481a862 
[ghstack-poisoned]
seemethere added a commit that referenced this pull request Feb 27, 2025
@seemethere
ci: Remove manylinux 2014 remnants
6d9f985 
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

ghstack-source-id: a8b0333
Pull Request resolved: #148028

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Copy link
Member Author

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@seemethere @majing921201
ci: Remove manylinux 2014 remnants (pytorch#148028)
8d0408a 
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/

> [!TIP]
> I checked if we were using these by running
> `rg 2014 .github/`

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Pull Request resolved: pytorch#148028
Approved by: https://github.com/wdvr, https://github.com/malfet, https://github.com/atalman
@github-actions github-actions bot deleted the gh/seemethere/9/head branch March 30, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn left review comments

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

@wdvr wdvr wdvr approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seemethere @pytorchmergebot @huydhn @malfet @atalman @wdvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.