Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Prevent _legacy_load with weights_only=True #144914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Prevent _legacy_load with weights_only=True #144914

wants to merge 6 commits into from

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Jan 16, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144914

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 41 Pending, 6 Unrelated Failures

As of commit 842e9ee with merge base 62ce3e6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
deb5bf2 
ghstack-source-id: 528ab1f
Pull Request resolved: #144914
@mikaylagawarecki mikaylagawarecki added release notes: python_frontend python frontend release notes category topic: improvements topic category labels Jan 16, 2025
mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
8b62afd 
ghstack-source-id: 612dde6
Pull Request resolved: #144914
mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
d2709d6 
ghstack-source-id: f5f4e91
Pull Request resolved: #144914
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Jan 16, 2025
mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
fed5c9b 
ghstack-source-id: 3c0cc27
Pull Request resolved: #144914
albanD
albanD reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks great, just test config needs updating!

@mikaylagawarecki mikaylagawarecki added the keep-going Don't stop on first failure, keep running tests until the end label Jan 16, 2025
mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
27ce04f 
ghstack-source-id: 77ceee2
Pull Request resolved: #144914
mikaylagawarecki added a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki
Prevent _legacy_load with weights_only=True
facb74f 
ghstack-source-id: a883664
Pull Request resolved: #144914
@mikaylagawarecki mikaylagawarecki added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 16, 2025
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@mikaylagawarecki mikaylagawarecki removed the release notes: quantization release notes category label Jan 16, 2025
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review January 16, 2025 18:11
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot help

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot -h cherry-pick

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/2.6 -c critical

pytorchbot pushed a commit that referenced this pull request Jan 16, 2025
@mikaylagawarecki @pytorchbot
Prevent _legacy_load with weights_only=True (#144914)
81eff30 
Pull Request resolved: #144914
Approved by: https://github.com/malfet, https://github.com/albanD

(cherry picked from commit 7c3aa1d)
@pytorchbot pytorchbot mentioned this pull request Jan 16, 2025
Merged
@pytorchbot
Copy link
Collaborator

Cherry picking #144914

The cherry pick PR is at #144993 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jan 16, 2025
Closed
@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "breaking inductor on trunk" -c nocignal

please see
https://github.com/pytorch/pytorch/actions/runs/12816267609/job/35737786985
https://github.com/pytorch/pytorch/actions/runs/12816267609/job/35737784830
https://github.com/pytorch/pytorch/actions/runs/12816267609/job/35737786985

I also added ciflow/inductor label.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: argument -c/--classification: invalid choice: 'nocignal' (choose from 'nosignal', 'ignoredsignal', 'landrace', 'weird', 'ghfirst')

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "breaking inductor on trunk" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jan 16, 2025
@pytorchmergebot
Revert "Prevent _legacy_load with weights_only=True (#144914)"
aa4a1ff 
This reverts commit 7c3aa1d.

Reverted #144914 on behalf of https://github.com/izaitsevfb due to breaking inductor on trunk ([comment](#144914 (comment)))
@pytorchmergebot
Copy link
Collaborator

@mikaylagawarecki your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jan 16, 2025
kit1980 pushed a commit that referenced this pull request Jan 16, 2025
@pytorchbot @mikaylagawarecki
Prevent _legacy_load with weights_only=True (#144993)
cd15d7b 
Prevent _legacy_load with weights_only=True (#144914)

Pull Request resolved: #144914
Approved by: https://github.com/malfet, https://github.com/albanD

(cherry picked from commit 7c3aa1d)

Co-authored-by: Mikayla Gawarecki <mikaylagawarecki@gmail.com>
@mikaylagawarecki
Copy link
Contributor Author

Closing in favor of #145020

@github-actions github-actions bot deleted the gh/mikaylagawarecki/305/head branch February 16, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@albanD albanD albanD approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged release notes: python_frontend python frontend release notes category Reverted topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikaylagawarecki @pytorchmergebot @pytorchbot @izaitsevfb @malfet @albanD
Morty Proxy This is a proxified and sanitized view of the page, visit original site.