Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Defaults to C++20 in CMake torch targets #143959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Draft

Defaults to C++20 in CMake torch targets #143959

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Dec 29, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143959

Note: Links to docs will display an error until the docs builds have been completed.

❌ 25 New Failures, 2 Unrelated Failures

As of commit 83c9be2 with merge base 3c74a72 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft December 29, 2024 16:36
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 30, 2024
@cyyever cyyever force-pushed the cxx20 branch 4 times, most recently from 2067e96 to 67159ad Compare December 30, 2024 03:21
@cyyever cyyever changed the title Defaults to C++20 in CPU builds Defaults to C++20 in CMake CPU targets Dec 30, 2024
@cyyever cyyever added release notes: build release notes category topic: build module: cpp Related to C++ API and removed module: cpu CPU specific problem (e.g., perf, algorithm) labels Dec 30, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Dec 30, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 30, 2024
@cyyever cyyever added ciflow/s390 s390x-related CI jobs ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Dec 30, 2024
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 30, 2024
@cyyever cyyever changed the title Defaults to C++20 in CMake CPU targets Defaults to C++20 in CMake torch targets Dec 30, 2024
@cyyever cyyever force-pushed the cxx20 branch 4 times, most recently from 3c27707 to ac7553e Compare December 30, 2024 08:40
@pytorch-bot pytorch-bot bot added the NNC label Jan 29, 2025
@cyyever cyyever force-pushed the cxx20 branch 3 times, most recently from 9218259 to c32f4a4 Compare January 31, 2025 07:05
@cyyever cyyever force-pushed the cxx20 branch 3 times, most recently from af29495 to 7139b9c Compare March 26, 2025 08:53
@cyyever cyyever force-pushed the cxx20 branch 5 times, most recently from 29197aa to ec6789f Compare May 7, 2025 04:13
@cyyever
Copy link
Collaborator Author

cyyever commented May 29, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cxx20 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout cxx20 && git pull --rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/s390 s390x-related CI jobs module: cpp Related to C++ API module: cpu CPU specific problem (e.g., perf, algorithm) NNC open source release notes: build release notes category topic: build topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyyever @pytorchmergebot @pytorchbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.