Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add windows CUDA 12.6 nightly builds #141805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 29, 2024

Windows AMI was published to prod. This PR adds CUDA 12.6 nightly builds

cc @albanD

@atalman atalman requested a review from a team as a code owner November 29, 2024 17:24
Copy link

pytorch-bot bot commented Nov 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141805

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 9 Unrelated Failures

As of commit 4da4393 with merge base 7dd9b5f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 29, 2024
@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Nov 29, 2024
@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 29, 2024

@atalman I just want to make sure that CUDNN is upgraded on Windows and CUDA is set to 12.6.3

@atalman
Copy link
Contributor Author

atalman commented Nov 29, 2024

Hi @Skylion007 cudnn is updated, yes. Cutlass maybe different which is acceptable. As per discussion with @ptrblck @malfet @tinglvv @nWEIdia

@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 29, 2024

@atalman Ah sorry, typo'd meant CUDA / CUBLAS. We are actually still way behind on CUTLASS and need to update it for all our backends at some point. See #131493

@atalman atalman added the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Nov 29, 2024
@atalman
Copy link
Contributor Author

atalman commented Nov 30, 2024

@pytorchmergebot merge -f "Windows CUDA 12.6 and lint are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Windows AMI was published to prod. This PR adds CUDA 12.6 nightly builds

Pull Request resolved: pytorch#141805
Approved by: https://github.com/huydhn, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged skip-pr-sanity-checks topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.