Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[EZ] Get rid of utf-8 quotes #124932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

[EZ] Get rid of utf-8 quotes #124932

merged 1 commit into from
Apr 25, 2024

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Apr 25, 2024 •
edited
Loading

Replace “important” with "important" and Taylor’s with Taylor's

Fixes the obvious symptoms of #124897

Test plan: Download wheel and check that generated VF.pyi does not have any unicode characters by running following command:

% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"

@malfet
[EZ] Get rid of utf-8 quotes
ed86e37 
Replace `“important”` with `important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of #124897
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124932

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit ed86e37 with merge base 1ac402a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Apr 25, 2024
@malfet malfet added ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR and removed release notes: python_frontend python frontend release notes category labels Apr 25, 2024
@malfet malfet requested review from albanD and a team April 25, 2024 12:59
@malfet malfet added the topic: docs topic category label Apr 25, 2024
@albanD
Copy link
Collaborator

albanD commented Apr 25, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 25, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@albanD albanD added topic: not user facing topic category and removed topic: docs topic category labels Apr 25, 2024
@albanD
Copy link
Collaborator

albanD commented Apr 25, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Apr 25, 2024

@pytorchbot merge -f "Doc and wheel builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command `git -C /home/runner/work/pytorch/pytorch commit --author="Nikita Shulga 2453524+malfet@users.noreply.github.com" -m [EZ] Get rid of utf-8 quotes (#124932)

Replace “important” with important" and Taylor’s with Taylor's

Fixes the obvious symptoms of #124897

Test plan: Download wheel and check that generated VF.pyi does not have any unicode characters by running following command:

% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"

Pull Request resolved: #124932
Approved by: https://github.com/albanD, https://github.com/ZainRizvi
` returned non-zero exit code 1

On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Apr 25, 2024

@pytorchbot merge -f "Doc and wheel builds are green"

@malfet malfet mentioned this pull request Apr 25, 2024
Open
@edoaltamura edoaltamura mentioned this pull request Apr 30, 2024
Merged
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@malfet @petrex
[EZ] Get rid of utf-8 quotes (#124932)
8fe2cd3 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of #124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
@atalman
Copy link
Contributor

atalman commented May 13, 2024

@pytorchbot cherry-pick --onto release/2.3 -c regression --critical

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 13, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: --critical

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@atalman
Copy link
Contributor

atalman commented May 13, 2024

@pytorchbot cherry-pick --onto release/2.3 -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #124932

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x -X theirs 977dc5593a123305dfebe38fc93849f4f4ba1080 returned non-zero exit code 1

The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch cherry-pick-124932-by-pytorch_bot_bot_
You are currently cherry-picking commit 977dc5593a1.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
Details for Dev Infra team Raised by workflow job

@atalman atalman mentioned this pull request May 15, 2024
Closed
@github-actions github-actions bot deleted the malfet-patch-9 branch June 13, 2024 01:53
VRSinghHabana pushed a commit to VRSinghHabana/pytorch that referenced this pull request Jun 18, 2024
@malfet @VRSinghHabana
[EZ] Get rid of utf-8 quotes (pytorch#124932)
ca29f61 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of pytorch#124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
pytorchmergebot pushed a commit to VRSinghHabana/pytorch that referenced this pull request Jul 2, 2024
@malfet @pytorchmergebot
[EZ] Get rid of utf-8 quotes (pytorch#124932)
33d397c 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of pytorch#124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
pytorch-bot bot pushed a commit that referenced this pull request Jul 4, 2024
@malfet @pytorchmergebot
[EZ] Get rid of utf-8 quotes (#124932)
9ad9a18 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of #124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
pytorch-bot bot pushed a commit that referenced this pull request Jul 10, 2024
@malfet @pytorchmergebot
[EZ] Get rid of utf-8 quotes (#124932)
0d3948f 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of #124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
pytorch-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@malfet @pytorchmergebot
[EZ] Get rid of utf-8 quotes (#124932)
b8f4c3a 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of #124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
VRSinghHabana pushed a commit to VRSinghHabana/pytorch that referenced this pull request Jul 24, 2024
@malfet @VRSinghHabana
[EZ] Get rid of utf-8 quotes (pytorch#124932)
cabdc19 
Replace `“important”` with `"important"` and `Taylor’s` with `Taylor's`

Fixes the obvious symptoms of pytorch#124897

Test plan: Download [wheel](https://github.com/pytorch/pytorch/actions/runs/8833051644/artifacts/1447995459) and check that generated VF.pyi does not have any unicode characters by running following command:
```
% python3 -c "x=open('_VF.pyi', encoding='utf-8').read();uc=[(i, x[i]) for i in range(len(x)) if ord(x[i])>127];print(uc);assert(len(uc)==0)"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malfet @albanD @pytorchmergebot @atalman @pytorchbot @ZainRizvi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.