Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[export][reland] Disable exported_program.__call__ #120019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Feb 15, 2024

Copy link

pytorch-bot bot commented Feb 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120019

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 005f71f with merge base eba28a6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 16, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 20, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 20, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 22, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
angelayi added a commit to angelayi/pytorch that referenced this pull request Mar 4, 2024
Summary:

X-link: pytorch/executorch#1994

Reland of D53075378 / pytorch#119466

Test Plan: CI

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Mar 4, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

Summary:

X-link: pytorch/executorch#1994

Reland of D53075378 / pytorch#119466

Test Plan: CI

Reviewed By: suo

Differential Revision: D53827930
angelayi added a commit to angelayi/executorch-1 that referenced this pull request Mar 4, 2024
Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53827930

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Mar 5, 2024
Summary:
X-link: pytorch/pytorch#120019

Pull Request resolved: #1994

Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

fbshipit-source-id: 83554c86ea320a4d00c781c10bcfa71d6c3e6471
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@angelayi
Copy link
Contributor Author

angelayi commented Mar 5, 2024

Lintrunner fix here: #121205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo module: inductor release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.