[state_dict] Calls wait() for the DTensor to_local() result (#118197) #119692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…118197) See the discussion in pytorch#117799. There are some issues when returning a AsyncCollectiveTensor (haven't found the root causes), including OOM and unexpected values. This PR forces `_gather_state_dict()` to be synchronous with respect to the mian stream. Differential Revision: [D53049807](https://our.internmc.facebook.com/intern/diff/D53049807/) Pull Request resolved: pytorch#118197 Approved by: https://github.com/wz337, https://github.com/LucasLLC
…e dict loading (pytorch#119716) Summary: This PR serves as a follow-up fix to address numerical correctness concerns identified in PR pytorch#118197, and we should only wait on `AsyncCollectiveTensor`. Without the change, we occasionally ran into exception: `AttributeError("'Tensor' object has no attribute 'wait'")` Test Plan: **CI**: Wait for the CI test **Test with prod model**: - Tested with models and no-longer ran into the exception after checkpoint loading. Differential Revision: D53680406 Pull Request resolved: pytorch#119716 Approved by: https://github.com/fegin, https://github.com/Skylion007, https://github.com/wz337
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119692
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 341e7e9 with merge base a8bd593 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #117799.
There are some issues when returning a AsyncCollectiveTensor (haven't found the root causes), including OOM and unexpected values.
This PR forces
_gather_state_dict()to be synchronous with respect to the mian stream.Differential Revision: D53049807
Pull Request resolved: #118197
Approved by: https://github.com/wz337, https://github.com/LucasLLC
Fixes #ISSUE_NUMBER