Fix TCP Store Windows #118860
Closed
Fix TCP Store Windows #118860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing call to addMiscellaneousSocket on Windows
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118860
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f5d3305 with merge base eebe7e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
awgu
approved these changes
Feb 1, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
approved these changes
Feb 1, 2024
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
In #107607 there was added a new Validate flow, however on Windows it was not calling addMiscellaneousSocket. Added missing call to addMiscellaneousSocket on Windows. Fixes #118737 Pull Request resolved: #118860 Approved by: https://github.com/awgu, https://github.com/malfet
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Feb 13, 2024
In pytorch#107607 there was added a new Validate flow, however on Windows it was not calling addMiscellaneousSocket. Added missing call to addMiscellaneousSocket on Windows. Fixes pytorch#118737 Pull Request resolved: pytorch#118860 Approved by: https://github.com/awgu, https://github.com/malfet
This was referenced Feb 13, 2024
atalman
added a commit
that referenced
this pull request
Feb 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #107607 there was added a new Validate flow, however on Windows it was not calling addMiscellaneousSocket.
Added missing call to addMiscellaneousSocket on Windows.
Fixes #118737
Tested by running
python test/distributed/test_launcher.pycc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225