Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 23961ce

Browse filesBrowse files
pytorchbothuydhn
pytorchbot
and
huydhn
authored
[Release/2.3] Set py3.x build-environment name consistently (#123446)
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6 Pull Request resolved: #122247 Approved by: https://github.com/malfet (cherry picked from commit 6fefc52) Co-authored-by: Huy Do <huydhn@gmail.com>
1 parent 634cf50 commit 23961ce
Copy full SHA for 23961ce

File tree

Expand file treeCollapse file tree

2 files changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-4
lines changed

‎.github/workflows/inductor.yml

Copy file name to clipboardExpand all lines: .github/workflows/inductor.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
name: linux-jammy-cpu-py3.8-gcc11-inductor
112112
uses: ./.github/workflows/_linux-build.yml
113113
with:
114-
build-environment: linux-jammy-py3_8-gcc11-build
114+
build-environment: linux-jammy-py3.8-gcc11-build
115115
docker-image-name: pytorch-linux-jammy-py3.8-gcc11-inductor-benchmarks
116116
test-matrix: |
117117
{ include: [
@@ -135,7 +135,7 @@ jobs:
135135
uses: ./.github/workflows/_linux-test.yml
136136
needs: linux-jammy-cpu-py3_8-gcc11-inductor-build
137137
with:
138-
build-environment: linux-jammy-py3_8-gcc11-build
138+
build-environment: linux-jammy-py3.8-gcc11-build
139139
docker-image: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.docker-image }}
140140
test-matrix: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.test-matrix }}
141141
secrets:

‎.github/workflows/pull.yml

Copy file name to clipboardExpand all lines: .github/workflows/pull.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ jobs:
311311
name: linux-focal-py3_8-clang9-xla
312312
uses: ./.github/workflows/_linux-build.yml
313313
with:
314-
build-environment: linux-focal-py3_8-clang9-xla
314+
build-environment: linux-focal-py3.8-clang9-xla
315315
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/xla_base:v1.1-lite
316316
test-matrix: |
317317
{ include: [
@@ -323,7 +323,7 @@ jobs:
323323
uses: ./.github/workflows/_linux-test.yml
324324
needs: linux-focal-py3_8-clang9-xla-build
325325
with:
326-
build-environment: linux-focal-py3_8-clang9-xla
326+
build-environment: linux-focal-py3.8-clang9-xla
327327
docker-image: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.docker-image }}
328328
test-matrix: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.test-matrix }}
329329

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.